Skip to content

Traducción library/mimetypes #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 14, 2020
Merged

Traducción library/mimetypes #742

merged 22 commits into from
Sep 14, 2020

Conversation

ojoanalogo
Copy link

@ojoanalogo ojoanalogo commented Sep 6, 2020 •
edited
Loading

Closes #687

✔️ Listo

@ojoanalogo ojoanalogo changed the title Traducción library/minetypes Traducción library/mimetypes Sep 6, 2020
fjsevilla-dev
fjsevilla-dev reviewed Sep 6, 2020
View reviewed changes
Copy link
Contributor

@fjsevilla-dev fjsevilla-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola Alfonso, muy buen trabajo de traducción, había algunos problemas con Travis que justo estaba comentando en la revisión cuando hiciste tu último commit con el que has corregido la mayoría, solo se te ha escapado una comilla traicionera en una referencia. Aparte de eso te dejo algunos comentarios a ver que te parecen.

Alfonso Reyes and others added 10 commits September 6, 2020 12:32
@fjsevilla-dev
Update library/mimetypes.po
75331bd 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
7822b5d 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
9a86dfd 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
d6e0f57 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
21a3fe7 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
80a4168 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
ac13ddd 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
964796b 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
6738f01 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@fjsevilla-dev
Update library/mimetypes.po
4873563 
Co-authored-by: fjsevilla <fjsevilla2.0@gmail.com>
@ojoanalogo
Copy link
Author

Hola Alfonso, muy buen trabajo de traducción, había algunos problemas con Travis que justo estaba comentando en la revisión cuando hiciste tu último commit con el que has corregido la mayoría, solo se te ha escapado una comilla traicionera en una referencia. Aparte de eso te dejo algunos comentarios a ver que te parecen.

¡Gracias por tu revisión @fjsevilla-dev !

He aprobado cada una de ellas ya que cumplen con la intención de mejorar la redacción y calidad de la traducción, te agradezco por haberte tomado el tiempo de revisar cada una de ellas 😀

eamanu
eamanu reviewed Sep 7, 2020
View reviewed changes
@eamanu
Update library/mimetypes.po
f620d03 
Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
cmaureir
cmaureir requested changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un par de detallitos y estamos listos para el merge.

Alfonso Reyes and others added 8 commits September 12, 2020 22:02
@cmaureir
Update library/mimetypes.po
171763c 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
1e8d926 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
c0e8162 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
07eb9a6 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
a9b35b8 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
fd200ef 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
fcd5025 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@cmaureir
Update library/mimetypes.po
7bad724 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
eamanu
eamanu approved these changes Sep 13, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien

@eamanu
Copy link
Contributor

eamanu commented Sep 13, 2020

@cmaureir ya están los cambios de @mxarc

@cmaureir cmaureir merged commit 7dab0cd into python:3.8 Sep 14, 2020
@cmaureir
Copy link
Collaborator

Muchas gracias @mxarc !!! 🎉 🎉
gracias a los revisores también @eamanu y @fjsevilla-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjsevilla-dev fjsevilla-dev fjsevilla-dev left review comments

@cmaureir cmaureir cmaureir approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/mimetypes.po
4 participants
@ojoanalogo @eamanu @cmaureir @fjsevilla-dev