Skip to content

Remove errors from readme (gh-55) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

StanFromIreland
Copy link
Collaborator

No description provided.

@StanFromIreland
Copy link
Collaborator Author

I can't seem to find why it is also printing in the README. I have to wait and see if it prints in the Actions report too.

@StanFromIreland
Copy link
Collaborator Author

This is a temporary patch.

@StanFromIreland
Copy link
Collaborator Author

StanFromIreland commented Jan 24, 2025

It is because the function is called in the cog. We can't use print in the function if we wish to use it for the badge.

from manage_translation import get_resource_language_stats, progress_from_resources, get_number_of_translators

stats = get_resource_language_stats()
total = progress_from_resources(stats)
translators = get_number_of_translators()

There needs to be a different approach here. This patch is fine to fix it for now.

@StanFromIreland StanFromIreland changed the title Remove errors from readme Remove errors from readme (gh-55) Jan 24, 2025
@m-aciek m-aciek merged commit 2cdb724 into python:3.13 Jan 24, 2025
@StanFromIreland
Copy link
Collaborator Author

Ah, good idea!

@m-aciek
Copy link
Collaborator

m-aciek commented Jan 24, 2025

Thank you! I didn't test the changes locally 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants