Skip to content

Add pre-commit #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Add pre-commit #90

merged 2 commits into from
Jun 13, 2025

Conversation

StanFromIreland
Copy link
Collaborator

I've already done it once today so why not once more:-)

@StanFromIreland StanFromIreland requested a review from m-aciek June 9, 2025 19:21
Copy link
Collaborator

@m-aciek m-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments

Comment on lines +22 to +25
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.32.1
hooks:
- id: check-github-workflows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it superfluous to the actionlint?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the redundancy hurt, it is only a fraction of a second after all?

@StanFromIreland StanFromIreland requested a review from m-aciek June 10, 2025 15:36
@m-aciek m-aciek merged commit 67c204b into python:3.14 Jun 13, 2025
@StanFromIreland StanFromIreland deleted the pre-commit branch June 13, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants