Skip to content

Add pre-commit with powrap #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2023

Conversation

Shen-KuanLing
Copy link
Contributor

@Shen-KuanLing Shen-KuanLing commented Aug 21, 2023

Add powrap pre-commit hook to check and format staged po file(s)

Prerequisite of this hook:

  • execute pre-commit install to enable pre-commit hook

@mattwang44 mattwang44 self-requested a review August 21, 2023 21:05
@cschan1828 cschan1828 self-requested a review August 29, 2023 17:16
cschan1828
cschan1828 previously approved these changes Sep 2, 2023
Copy link
Collaborator

@cschan1828 cschan1828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that it works fine with the manual installation of pre-commit.

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感謝你辛苦了~

@mattwang44 mattwang44 enabled auto-merge (squash) September 4, 2023 15:47
@mattwang44 mattwang44 merged commit af9f3ef into python:3.12 Sep 4, 2023
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* feat: add pre-commit to format po files

* feat: use powrap native pre-commit hook

* PR reviewer suggestions

* chore(readme): add installation cmd for pre-commit

---------

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants