-
-
Notifications
You must be signed in to change notification settings - Fork 214
Add pre-commit with powrap #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattwang44
merged 6 commits into
python:3.12
from
Shen-KuanLing:feat/pre-commit-with-powrap
Sep 4, 2023
Merged
Add pre-commit with powrap #608
mattwang44
merged 6 commits into
python:3.12
from
Shen-KuanLing:feat/pre-commit-with-powrap
Sep 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschan1828
previously approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that it works fine with the manual installation of pre-commit
.
mattwang44
reviewed
Sep 4, 2023
mattwang44
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感謝你辛苦了~
beccalzh
pushed a commit
to beccalzh/python-docs-zh-tw
that referenced
this pull request
Sep 4, 2024
* feat: add pre-commit to format po files * feat: use powrap native pre-commit hook * PR reviewer suggestions * chore(readme): add installation cmd for pre-commit --------- Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add powrap pre-commit hook to check and format staged po file(s)
Prerequisite of this hook:
pre-commit install
to enable pre-commit hook