Skip to content

python >=3.8: cmath functions should accept any object with __index__ #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Akuli opened this issue Oct 30, 2021 · 0 comments · Fixed by #6216
Closed

python >=3.8: cmath functions should accept any object with __index__ #6214

Akuli opened this issue Oct 30, 2021 · 0 comments · Fixed by #6216

Comments

@Akuli
Copy link
Collaborator

Akuli commented Oct 30, 2021

runtime:

akuli@akuli-desktop:/tmp$ cat asd.py
class Foo:
    def __index__(self):
        return 1
akuli@akuli-desktop:/tmp$ python3.7 -c 'import cmath, asd; cmath.sin(asd.Foo())'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
TypeError: must be real number, not Foo
akuli@akuli-desktop:/tmp$ python3.8 -c 'import cmath, asd; cmath.sin(asd.Foo())'
akuli@akuli-desktop:/tmp$

(The error message is wrong, the functions also accept complex numbers)

Stub:

typeshed/stdlib/cmath.pyi

Line 11 in 05cc30b

_C = Union[SupportsFloat, SupportsComplex, complex]

typeshed/stdlib/cmath.pyi

Line 30 in 05cc30b

def sin(__z: _C) -> complex: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update SupportsIndex support for math and cmath A5rocks/typeshed
1 participant
@Akuli