Skip to content

Figure out how to enable pyright's reportUnnecessaryTypeIgnoreComment setting for the whole test_cases directory #8506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWaygood opened this issue Aug 8, 2022 · 0 comments · Fixed by #8683
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 8, 2022

Currently, we have mypy's --warn-unused-ignore setting enabled for the whole test_cases directory, but for pyright, we have to manually add # pyright: reportUnnecessaryTypeIgnoreComment=true at the top of each file in the directory. These settings are crucial to these tests working properly; none of our tests against false-negatives work properly without them.

It would be good if we could work out how to get # pyright: reportUnnecessaryTypeIgnoreComment=true enabled for the whole directory. The current system is error-prone: if we forget to add it at the top of a file, any tests against false negatives could fail silently on pyright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
1 participant