From 799764febb17cf57130b00c859abe41e4c1632b4 Mon Sep 17 00:00:00 2001 From: Jelle Zijlstra Date: Sat, 10 Dec 2022 10:37:40 -0800 Subject: [PATCH 1/3] [DO NOT MERGE] check that test case is working as expected cf. #9348 cc @jab --- test_cases/stdlib/typing/check_regression_issue_9296.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_cases/stdlib/typing/check_regression_issue_9296.py b/test_cases/stdlib/typing/check_regression_issue_9296.py index 34c5631aeb1a..f1a821e442d3 100644 --- a/test_cases/stdlib/typing/check_regression_issue_9296.py +++ b/test_cases/stdlib/typing/check_regression_issue_9296.py @@ -13,4 +13,4 @@ class MyKeysView(t.KeysView[KT]): dict_keys = type(d.keys()) # This should not cause an error like `Member "register" is unknown`: -MyKeysView.register(dict_keys) +MyKeysView.regixster(dict_keys) From 0f1719dcacef0d176da2a6bdb2760e14b8affd7a Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Sat, 10 Dec 2022 21:13:37 +0000 Subject: [PATCH 2/3] Improve mypy traceback --- tests/regr_test.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/regr_test.py b/tests/regr_test.py index 37d09ef9c26e..87be4f8c8d7a 100644 --- a/tests/regr_test.py +++ b/tests/regr_test.py @@ -89,9 +89,9 @@ def test_testcase_directory(package: PackageInfo, version: str, platform: str, q package_name, test_case_directory = package is_stdlib = package_name == "stdlib" + msg = f"Running mypy --platform {platform} --python-version {version} on the " + msg += "standard library test cases..." if is_stdlib else f"test cases for {package_name!r}..." if not quiet: - msg = f"Running mypy --platform {platform} --python-version {version} on the " - msg += "standard library test cases..." if is_stdlib else f"test cases for {package_name!r}..." print(msg, end=" ") # "--enable-error-code ignore-without-code" is purposefully ommited. See https://github.com/python/typeshed/pull/8083 @@ -152,6 +152,11 @@ def test_testcase_directory(package: PackageInfo, version: str, platform: str, q result = subprocess.run([sys.executable, "-m", "mypy", *flags], capture_output=True, env=env_vars) if result.returncode: + if quiet: + # We'll already have printed this if --quiet wasn't passed. + # If--quiet was passed, only print this if there were errors. + # If there are errors, the output is inscrutable if this isn't printed. + print(msg, end=" ") print_error("failure\n") replacements = (str(new_test_case_dir), str(test_case_directory)) if result.stderr: From ba41cde673463b14e10a83447f4874591f9897c5 Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Sat, 10 Dec 2022 21:29:49 +0000 Subject: [PATCH 3/3] Regixster??? --- test_cases/stdlib/typing/check_regression_issue_9296.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_cases/stdlib/typing/check_regression_issue_9296.py b/test_cases/stdlib/typing/check_regression_issue_9296.py index f1a821e442d3..34c5631aeb1a 100644 --- a/test_cases/stdlib/typing/check_regression_issue_9296.py +++ b/test_cases/stdlib/typing/check_regression_issue_9296.py @@ -13,4 +13,4 @@ class MyKeysView(t.KeysView[KT]): dict_keys = type(d.keys()) # This should not cause an error like `Member "register" is unknown`: -MyKeysView.regixster(dict_keys) +MyKeysView.register(dict_keys)