According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Also, over at Black we have a similar system called diff-shades, and there we get around the comment length limit by printing the full diff to the action's log instead and linking to it. It's a little less convenient, but we could consider it as an option for very long diffs if we think it's important to be able to see the full comment. I'd personally consider it overkill since a very long mypy-primer diff is usually enough indication that a change is a bad idea.

Also, over at Black we have a similar system called diff-shades, and there we get around the comment length limit by printing the full diff to the action's log instead and linking to it. It's a little less convenient, but we could consider it as an option for very long diffs if we think it's important to be able to see the full comment. I'd personally consider it overkill since a very long mypy-primer diff is usually enough indication that a change is a bad idea.

Interesting, that sounds like overkill for typeshed, but might be pretty useful for mypy. It would have been very useful to easily see the full diffs for the typing.Self PRs, where the diff was often huge because of the number of projects that were already using typing.Self, despite it being unsupported by mypy. And there's value in keeping the workflow relatively in sync across the two projects; it's less cognitive load for maintainers.

Note that the action prints the full diff! This is purely for convenience with the comment since I hit the old limit recently with a legit PR.
Splitting the comment might be overkill for typeshed and flake8-pyi's primers. But if it can link to the action run when truncating that could be a nice qol improvement.

The full diffs are available for download if you click through.

To Alex's suggestion for mypy: we now have per project truncation on mypy.

Avasam, do you have a PR in mind where 30k chars more of comment would have been useful?

Avasam, do you have a PR in mind where 30k chars more of comment would have been useful?

I think probably #9597

Avasam, do you have a PR in mind where 30k chars more of comment would have been useful?

I think probably #9597

~3.5k for that one in its current state (24 truncated lines). While working on it I easily had 80+ truncated lines of legit diff I had to go through.
Also I had up to 230+ truncated lines (which would result in 35-40k+ additional chars) at some point because of some generics-related changes, but decided to revert that and keep for later. ie:

- <something about> Row
+ <something about> Row[Any]

The idea is more that if we limit the length for technical reasons, may as well get closer to the limit, not halfway there (and it doesn't negatively affect readability). In other words, making the limit less arbitrary.

Truncating in multiple comments is something that can be done if someone wants to tackle it, but this hard-limit would still be relevant, and is likely still gonna be hit from the homeassistant project alone once I tackle SQLAlchemy generics.