Skip to content

Commit 0a82909

Browse files
committed
remove duplicate code for omega determination
1 parent db174b7 commit 0a82909

File tree

1 file changed

+9
-23
lines changed

1 file changed

+9
-23
lines changed

control/freqplot.py

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -675,26 +675,13 @@ def nyquist_plot(syslist, omega=None, plot=True, omega_limits=None,
675675
if not hasattr(syslist, '__iter__'):
676676
syslist = (syslist,)
677677

678-
# Decide whether to go above Nyquist frequency
679-
omega_range_given = True if omega is not None else False
680-
681-
# Figure out the frequency limits
682-
if omega is None:
683-
if omega_limits is None:
684-
# Select a default range if none is provided
685-
omega = _default_frequency_range(
686-
syslist, number_of_samples=omega_num)
687-
688-
# Replace first point with the origin
689-
omega[0] = 0
690-
else:
691-
omega_range_given = True
692-
omega_limits = np.asarray(omega_limits)
693-
if len(omega_limits) != 2:
694-
raise ValueError("len(omega_limits) must be 2")
695-
omega = np.logspace(np.log10(omega_limits[0]),
696-
np.log10(omega_limits[1]), num=omega_num,
697-
endpoint=True)
678+
omega, omega_range_given = _determine_omega_vector(syslist,
679+
omega,
680+
omega_limits,
681+
omega_num)
682+
if not omega_range_given:
683+
# Replace first point with the origin
684+
omega[0] = 0
698685

699686
# Go through each system and keep track of the results
700687
counts, contours = [], []
@@ -1235,16 +1222,15 @@ def _determine_omega_vector(syslist, omega_in, omega_limits, omega_num):
12351222
and omega_limits are None.
12361223
"""
12371224

1238-
# Decide whether to go above Nyquist frequency
1239-
omega_range_given = True if omega_in is not None else False
1225+
omega_range_given = True
12401226

12411227
if omega_in is None:
12421228
if omega_limits is None:
1229+
omega_range_given = False
12431230
# Select a default range if none is provided
12441231
omega_out = _default_frequency_range(syslist,
12451232
number_of_samples=omega_num)
12461233
else:
1247-
omega_range_given = True
12481234
omega_limits = np.asarray(omega_limits)
12491235
if len(omega_limits) != 2:
12501236
raise ValueError("len(omega_limits) must be 2")

0 commit comments

Comments
 (0)