SISO tf() may not work with numpy arrays with numpy.int elements.

kangwonlee · kangwonlee · commit facfe9c49d79 · 2017-10-23T01:14:18.000+09:00
diff --git a/control/tests/tf_input_element_int.py b/control/tests/tf_input_element_int.py
@@ -0,0 +1,46 @@
+import unittest
+
+import numpy as np
+
+import control as ctl
+
+
+class TestTfInputIntElement(unittest.TestCase):
+    # currently these do not pass
+    def test_tf_den_with_numpy_int_element(self):
+        num = 1
+        den = np.convolve([1, 2, 1], [1, 1, 1])
+
+        sys = ctl.tf(num, den)
+
+        self.assertAlmostEqual(1.0, ctl.dcgain(sys))
+
+    def test_tf_num_with_numpy_int_element(self):
+        num = np.convolve([1], [1, 1])
+        den = np.convolve([1, 2, 1], [1, 1, 1])
+
+        sys = ctl.tf(num, den)
+
+        self.assertAlmostEqual(1.0, ctl.dcgain(sys))
+
+    # currently these pass
+    def test_tf_input_with_int_element_works(self):
+        num = 1
+        den = np.convolve([1.0, 2, 1], [1, 1, 1])
+
+        sys = ctl.tf(num, den)
+
+        self.assertAlmostEqual(1.0, ctl.dcgain(sys))
+
+    def test_ss_input_with_int_element(self):
+        ident = np.matrix(np.identity(2), dtype=int)
+        a = np.matrix([[0, 1],
+                       [-1, -2]], dtype=int) * ident
+        b = np.matrix([[0],
+                       [1]], dtype=int)
+        c = np.matrix([[0, 1]], dtype=int)
+        d = 0
+
+        sys = ctl.ss(a, b, c, d)
+        sys2 = ctl.ss2tf(sys)
+        self.assertAlmostEqual(ctl.dcgain(sys), ctl.dcgain(sys2))
