-
Notifications
You must be signed in to change notification settings - Fork 438
pzmap() function not work, zero not plotted #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you provide a code snippet that generates both errors? Thanks. |
Hi Murray, tf = control.TransferFunction([1,1],[1,1,1])
control.pzmap(tf) It reports,
control.matlab.pzmap(tf) is working fine except that zeros are not shown. if len(zeros) > 0:
plt.scatter(real(zeros), imag(zeros), s=50, marker='o', facecolors='none') The zeros are shown after removing facecolors setting. It seems the 2 pzmap functions are essentially the same one. Sorry I'm not coder and can't digg too much. Thanks very much. |
so, completing the example from above to include necessary imports and the import matplotlib.pyplot as plt
import control
tf = control.TransferFunction([1,1],[1,1,1])
control.pzmap(tf)
plt.show() |
I am able to reproduce the reported behavior of missing zero markers. My hypothesis is some previous version of Matplotlib included marker edges by default, so if len(zeros) > 0:
plt.scatter(real(zeros), imag(zeros), s=50, marker='o',
facecolors='none', edgecolors='g') |
regarding the |
@Fankbai context? |
|
PR #193 addresses it |
Fixed in PR #193. |
For the same control.TransferFunction() sys, if I called with python version control.pzmap(), it reports that
If called control.matlab.pzmap() it does plot the poles but not zeros. I checked the code that when plotting zeros, facecolors is set to 'none'.
How can I change the color back? I think it's more reasonable to set a proper color for this line.
Thanks.
The text was updated successfully, but these errors were encountered: