Skip to content

Any plan for step_info to support negative step responses? #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hgducharme opened this issue Aug 21, 2019 · 4 comments · Fixed by #567
Closed

Any plan for step_info to support negative step responses? #337

hgducharme opened this issue Aug 21, 2019 · 4 comments · Fixed by #567
Labels
bug enhancement
Milestone
0.9.1

Comments

@hgducharme
Copy link

hgducharme commented Aug 21, 2019 •
edited
Loading

I have step responses that go negative and sometimes stay negative, and it breaks the settling time calculation and rise time calculation. I've been messing around with it and might open a pull request if this is something y'all would be interested in.

For example, here is my code, the step response plot, and the error

from control import tf, step_response, step_info
import matplotlib.pyplot as plt
import numpy as np

transfer_function = tf( [3.32, 0, -162.8], [1, 24.56, 186.5, 457.8, 116.2] )
time, response = step_response(transfer_function)

fig, ax = plt.subplots(1, 1)
ax.plot(time, response)
plt.show()

step_info(transfer_function)

step_response

step_info() gives the following error

Traceback (most recent call last):
  File "bug_test.py", line 14, in <module>
    step_info(transfer_function)
  File "/Users/hgducharme/Programming/pendulum/env/lib/python3.7/site-packages/control/timeresp.py", line 536, in step_info
    SettlingTime = T[i + 1]
IndexError: index 1000 is out of bounds for axis 0 with size 1000

When I run this code in MATLAB, I get the following result


Screen Shot 2019-08-20 at 8 36 44 PM
@murrayrm
Copy link
Member

@joaoantoniocardoso Any interest in taking a look at this?

@joaoantoniocardoso
Copy link
Contributor

joaoantoniocardoso commented Aug 21, 2019 •
edited
Loading

@murrayrm Yes, I think I can take a look at this tomorrow.

Also I think this error is not something that happens only for negative step responses... Months ago I did a pull-request (#293 ) that fixes some cases with the same message. (That pull was closed because while fixes some cases, it breaks others)

@murrayrm murrayrm added this to the 0.9.x milestone Dec 26, 2020
@murrayrm murrayrm mentioned this issue Mar 4, 2021
Merged
@juanodecc
Copy link
Contributor

Hi, think I solved this problem and the problem of systems with non settling time, I mean when dcgain isinf or isnan, doing:

    # Steady state value
    InfValue = sys1.dcgain()
    if InfValue < 0.0:
        yout = -yout
        InfValue = np.abs(InfValue)




    # SettlingTime
    sup_margin = (1. + SettlingTimeThreshold) * np.abs(InfValue)
    inf_margin = (1. - SettlingTimeThreshold) * np.abs(InfValue)
    # find Steady State looking for the first point out of specified limits
    if np.isnan(InfValue) or np.isinf(InfValue):
        SettlingTime = np.NaN
    else:
        for i in reversed(range(time.size-1)):
            if((np.abs(yout[i]) <= inf_margin) | (np.abs(yout[i]) >= sup_margin)):
                SettlingTime = T[i + 1]
                break

@joaoantoniocardoso
Copy link
Contributor

joaoantoniocardoso commented Mar 9, 2021 •
edited
Loading

Hi @juanodecc, it seems like a good solution. Could you open a PR with that, adding also a test case with a negative system and another with a system with non-settling time? Thanks

juanodecc added a commit to juanodecc/python-control that referenced this issue Mar 12, 2021
@juanodecc
Solve issue python-control#337, python-control#565 and python-control…
f964170 
…#564
@juanodecc juanodecc mentioned this issue Mar 12, 2021
Merged
@murrayrm murrayrm linked a pull request Mar 13, 2021 that will close this issue
Step info improve jpp #567
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

Step info improve jpp juanodecc/python-control
4 participants
@murrayrm @joaoantoniocardoso @hgducharme @juanodecc