Skip to content

coverall reports coverage decrease despite tests being added #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bnavigator opened this issue Nov 18, 2019 · 5 comments
Closed

coverall reports coverage decrease despite tests being added #349

bnavigator opened this issue Nov 18, 2019 · 5 comments
Assignees
@murrayrm
Milestone
0.8.3

Comments

@bnavigator
Copy link
Contributor

My recent pull requests enhanced some unit tests, but coverall reports a decrease in coverage.

I believe this happens because it counts the results from the travis jobs without slycot. Most of the unittests are skipped without slycot.
@bnavigator bnavigator mentioned this issue Nov 18, 2019
Merged
@bnavigator
Copy link
Contributor Author

See the reported decrease for my last contribution to #345 (commit d26d639):

It is compared to the master branch : "3875 of 4625 relevant lines covered (83.78%)"
but now counts many more lines : "26201 of 32361 relevant lines covered (80.96%)"

Something is broken with the coveralls setup.

@murrayrm
Copy link
Member

It looks like slycot may not be getting installed properly in the runs where it is supposed to be => code that relies on slycot is no longer being tested. Looking to see what is wrong...

@murrayrm murrayrm self-assigned this Dec 28, 2019
@murrayrm murrayrm mentioned this issue Dec 28, 2019
Merged
@murrayrm murrayrm added this to the 0.8.3 milestone Dec 29, 2019
@murrayrm
Copy link
Member

Fixed in PR #353.

@bnavigator
Copy link
Contributor Author

Coverage still does not count the correct line numbers or compares to a wrong reference. See #366

@bnavigator
Copy link
Contributor Author

I don't think this is fixed by #353. With my recent PR #370, coverall reports

3952 of 4670 relevant lines covered (84.63%)

but on the master build it is compared to

34471 of 41958 relevant lines covered (82.16%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murrayrm murrayrm

Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

No branches or pull requests
2 participants
@murrayrm @bnavigator