Skip to content

Add nonlinear system compatibility to time simulation functions #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
murrayrm opened this issue Jun 7, 2023 · 1 comment · Fixed by #916
Closed

Add nonlinear system compatibility to time simulation functions #906

murrayrm opened this issue Jun 7, 2023 · 1 comment · Fixed by #916
Milestone
0.10.0

Comments

@murrayrm
Copy link
Member

murrayrm commented Jun 7, 2023

As described in #905:

Any reason why initial_response, step_response, and forced_response can’t/shouldn’t be modified to be compatible with NonlinearIOSystems? It was a bit confusing to students in my class last quarter why they had to switch to a different simulation function if they included a nonlinear system in their InterconnectedSystem.

It should be possible to make all of the systems work for a NonlinearIOSystem.

For the impulse response, we could take the linearization of the system at the initial condition and then use that to reset the initial condition, though I'd want to think that through make sure that is the right thing to do mathematically.
@murrayrm murrayrm added this to the 0.10.0 milestone Jun 7, 2023
@murrayrm murrayrm mentioned this issue Jun 8, 2023
Merged
@murrayrm
Copy link
Member Author

murrayrm commented Jun 8, 2023

From #905:

As we move into 0.10 (see #904), I think we can do the following:

  • Allow initial_response and step_response to work for either linear or nonlinear systems.
  • Allow forced_response to take a nonzero X0 as an optional argument, but perhaps document it as mainly being there for the "pure" forced response, which at least one textbook defines as corresponding to X0=0 (FBS, page 6-3).
  • Use input_output_response as the general function for simulating a linear or nonlinear system for a specified input and initial condition (suggestions welcome for a better name).
  • Allow impulse_response only for linear systems (mainly because I think it is mainly useful for educational purposes when teaching linear control theory, convolution, etc).

@murrayrm murrayrm linked a pull request Jun 19, 2023 that will close this issue
I/O system class restructuring #916
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

I/O system class restructuring murrayrm/python-control
1 participant
@murrayrm