Skip to content

Use dict for package/module configuration parameters #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2019
Merged

Use dict for package/module configuration parameters #327

merged 2 commits into from
Jul 21, 2019

Conversation

murrayrm
Copy link
Member

This PR changes the way that the config module works to use a dictionary (config.defaults) to store the default parameter values for various functions. This change is transparent to the user, since the existing functional interfaces (use_fbs_defaults, use_matlab_defaults, reset_defaults, use_numpy_matrix) are unchanged.

I also took the opportunity to add a few more parameters to the list of defaults that can be set by the user, including parameters for the nichols, rlocus, and pzmap commands.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 83.192% when pulling d66db80 on murrayrm:config_via_dict into b5aaf4a on python-control:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 83.192% when pulling d66db80 on murrayrm:config_via_dict into b5aaf4a on python-control:master.

@murrayrm murrayrm mentioned this pull request Jul 15, 2019
Closed
@murrayrm murrayrm merged commit 4d718af into python-control:master Jul 21, 2019
@murrayrm murrayrm deleted the config_via_dict branch July 21, 2019 04:39
@murrayrm murrayrm added this to the 0.8.3 milestone Jan 4, 2020
repagh pushed a commit to repagh/python-control that referenced this pull request Jun 9, 2020
@murrayrm @repagh
Use dict for package/module configuration parameters (python-control#327
8745a15 
)

* update config module to use dictionary + 'module.variable' format to store configuration defaults
* create helper functions to allow processing of configuration parameters to functions
* update modules/functions that use configuration parameters to use the new config module functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@murrayrm @coveralls