discard zero imaginary part for sys.dcgain() #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murrayrm
reviewed
Mar 19, 2021
| @@ -448,7 +448,7 @@ def test_dcgain_consistency(): | |||
| np.testing.assert_equal( | |||
| sys_tf(0j, warn_infinite=False), complex(np.nan, np.nan)) | |||
| np.testing.assert_equal( | |||
| sys_tf.dcgain(warn_infinite=False), complex(np.nan, np.nan)) | |||
| sys_tf.dcgain(warn_infinite=False), np.nan) | |||
|
|
|||
There was a problem hiding this comment.
Consider adding a test to show that dcgain() on a system with negative gain at zero frequency returns a negative number.
There was a problem hiding this comment.
Already exists:
python-control/control/tests/freqresp_test.py
Lines 505 to 507 in 8c9e807
| @@ -1070,12 +1070,19 @@ def dcgain(self, warn_infinite=False): | |||
|
|
|||
| Returns | |||
| ------- | |||
| gain : ndarray | |||
| The zero-frequency gain | |||
| gain : (outputs, inputs) ndarray or scalar | |||
There was a problem hiding this comment.
gain : (noutputs, ninputs) ndarray or scalar
| zero-frequency (or DC) gain, or, if the frequency response is | ||
| singular, the array will be filled with (inf + nanj). | ||
|
|
||
| gain : (outputs, inputs) ndarray or scalar |
There was a problem hiding this comment.
gain : (noutputs, ninputs) ndarray or scalar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #578