fix zipimport ref leak

benjaminp · benjaminp · commit 7251fe10ffc1 · 2014-01-09T09:36:10.000-06:00
diff --git a/Modules/zipimport.c b/Modules/zipimport.c
@@ -832,10 +832,8 @@ safely_reopen_archive(ZipImporter *self, char **archive_p)
             }
             Py_XDECREF(self->files);  /* free the old value. */
             self->files = files;
-        } else {
-            /* No problem, discard the new stat data. */
-            Py_DECREF(stat_now);
         }
+        Py_DECREF(stat_now);
     }  /* stat succeeded */
 
     return fp;

Original file line number	Diff line number	Diff line change
`@@ -832,10 +832,8 @@ safely_reopen_archive(ZipImporter self, char *archive_p)`
`832`	`832`	`}`
`833`	`833`	`Py_XDECREF(self->files); /* free the old value. */`
`834`	`834`	`self->files = files;`
`835`		`- } else {`
`836`		`- /* No problem, discard the new stat data. */`
`837`		`- Py_DECREF(stat_now);`
`838`	`835`	`}`
	`836`	`+ Py_DECREF(stat_now);`
`839`	`837`	`} /* stat succeeded */`
`840`	`838`
`841`	`839`	`return fp;`