Skip to content

Commit 0717517

Browse files
nejchJohnVillalovos
authored andcommitted
feat(mixins): allow deleting resources without IDs
1 parent 5beda3b commit 0717517

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

gitlab/mixins.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ class DeleteMixin(_RestManagerBase):
463463
gitlab: gitlab.Gitlab
464464

465465
@exc.on_http_error(exc.GitlabDeleteError)
466-
def delete(self, id: Union[str, int], **kwargs: Any) -> None:
466+
def delete(self, id: Optional[Union[str, int]] = None, **kwargs: Any) -> None:
467467
"""Delete an object on the server.
468468
469469
Args:
@@ -478,6 +478,9 @@ def delete(self, id: Union[str, int], **kwargs: Any) -> None:
478478
path = self.path
479479
else:
480480
path = f"{self.path}/{utils.EncodedId(id)}"
481+
482+
if TYPE_CHECKING:
483+
assert path is not None
481484
self.gitlab.http_delete(path, **kwargs)
482485

483486

0 commit comments

Comments
 (0)