WIP: Trying to solve array issue

JohnVillalovos · JohnVillalovos · commit 0f0f8239d10a · 2021-11-18T16:10:05.000-08:00
diff --git a/gitlab/mixins.py b/gitlab/mixins.py
@@ -231,7 +231,17 @@ def list(self, **kwargs: Any) -> Union[base.RESTObjectList, List[base.RESTObject
             for attr_name, type_cls in self._types.items():
                 if attr_name in data.keys():
                     type_obj = type_cls(data[attr_name])
-                    data[attr_name] = type_obj.get_for_api()
+                    if isinstance(type_obj, g_types.ListAttribute):
+                        # NOTE(jlvillal): Array values are supposed to be
+                        # passed in the form of 'key[]=value1&key[]=value2'
+                        # https://docs.gitlab.com/ee/api/#array
+                        # But at the moment we haven't determined an elegant
+                        # way to do that. So for now just add the '[]' to the
+                        # key we send in the request.
+                        del data[attr_name]
+                        data[f"{attr_name}[]"] = type_obj.get_for_api()
+                    else:
+                        data[attr_name] = type_obj.get_for_api()
 
         # Allow to overwrite the path, handy for custom listings
         path = data.pop("path", self.path)
@@ -313,6 +323,15 @@ def create(
                     if isinstance(type_obj, g_types.FileAttribute):
                         k = type_obj.get_file_name(attr_name)
                         files[attr_name] = (k, data.pop(attr_name))
+                    elif isinstance(type_obj, g_types.ListAttribute):
+                        # NOTE(jlvillal): Array values are supposed to be
+                        # passed in the form of 'key[]=value1&key[]=value2'
+                        # https://docs.gitlab.com/ee/api/#array
+                        # But at the moment we haven't determined an elegant
+                        # way to do that. So for now just add the '[]' to the
+                        # key we send in the request.
+                        del data[attr_name]
+                        data[f"{attr_name}[]"] = type_obj.get_for_api()
                     else:
                         data[attr_name] = type_obj.get_for_api()
 
@@ -409,6 +428,15 @@ def update(
                     if isinstance(type_obj, g_types.FileAttribute):
                         k = type_obj.get_file_name(attr_name)
                         files[attr_name] = (k, new_data.pop(attr_name))
+                    elif isinstance(type_obj, g_types.ListAttribute):
+                        # NOTE(jlvillal): Array values are supposed to be
+                        # passed in the form of 'key[]=value1&key[]=value2'
+                        # https://docs.gitlab.com/ee/api/#array
+                        # But at the moment we haven't determined an elegant
+                        # way to do that. So for now just add the '[]' to the
+                        # key we send in the request.
+                        del new_data[attr_name]
+                        new_data[f"{attr_name}[]"] = type_obj.get_for_api()
                     else:
                         new_data[attr_name] = type_obj.get_for_api()
 
