fix: handle large number of approval rules

JohnVillalovos · nejch · commit 0f30a6f9d824 · 2024-05-17T12:06:06.000+02:00
Use `iterator=True` when going through the list of current approval rules. This allows it to handle more than the default of 20 approval rules. Closes: #2825
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -122,7 +122,7 @@ def set_approvers(
             self._parent.approval_rules
         )
         # update any existing approval rule matching the name
-        existing_approval_rules = approval_rules.list()
+        existing_approval_rules = approval_rules.list(iterator=True)
         for ar in existing_approval_rules:
             if ar.name == approval_rule_name:
                 ar.user_ids = data["user_ids"]

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ def set_approvers(`
`122`	`122`	`self._parent.approval_rules`
`123`	`123`	`)`
`124`	`124`	`# update any existing approval rule matching the name`
`125`		`- existing_approval_rules = approval_rules.list()`
	`125`	`+ existing_approval_rules = approval_rules.list(iterator=True)`
`126`	`126`	`for ar in existing_approval_rules:`
`127`	`127`	`if ar.name == approval_rule_name:`
`128`	`128`	`ar.user_ids = data["user_ids"]`