fix(cli): project-merge-request-approval-rule

JohnVillalovos · JohnVillalovos · commit 15a242c33037 · 2022-06-18T09:01:20.000-07:00
Using the CLI the command: gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar Would raise an exception. This was due to the fact that `_id_attr` and `_repr_attr` were set for keys which are not returned in the response. Add a unit test which shows the `repr` function now works. Before it did not. This is an EE feature so we can't functional test it. Closes: #2065
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -165,8 +165,7 @@ def set_approvers(
 
 
 class ProjectMergeRequestApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject):
-    _id_attr = "approval_rule_id"
-    _repr_attr = "approval_rule"
+    _repr_attr = "name"
     id: int
     approval_rule_id: int
     merge_request_iid: int
diff --git a/tests/unit/objects/test_project_merge_request_approvals.py b/tests/unit/objects/test_project_merge_request_approvals.py
@@ -168,6 +168,7 @@ def test_list_merge_request_approval_rules(project, resp_mr_approval_rules):
     assert len(approval_rules) == 1
     assert approval_rules[0].name == approval_rule_name
     assert approval_rules[0].id == approval_rule_id
+    repr(approval_rules)  # ensure that `repr()` doesn't raise an exception
 
 
 def test_delete_merge_request_approval_rule(project, resp_delete_mr_approval_rule):
