Merge pull request #725 from python-gitlab/fix/699

max-wittig · web-flow · commit 17924424e511 · 2019-03-04T09:10:23.000+01:00
fix(api): Make *MemberManager.all() return a list of objects
diff --git a/RELEASE_NOTES.rst b/RELEASE_NOTES.rst
@@ -4,6 +4,13 @@ Release notes
 
 This page describes important changes between python-gitlab releases.
 
+Changes from 1.8 to 1.9
+=======================
+
+* ``ProjectMemberManager.all()`` and ``GroupMemberManager.all()`` now return a
+  list of ``ProjectMember`` and ``GroupMember`` objects respectively, instead
+  of a list of dicts.
+
 Changes from 1.7 to 1.8
 =======================
 
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
@@ -740,7 +740,8 @@ def all(self, **kwargs):
         """
 
         path = '%s/all' % self.path
-        return self.gitlab.http_list(path, **kwargs)
+        obj = self.gitlab.http_list(path, **kwargs)
+        return [self._obj_cls(self, item) for item in obj]
 
 
 class GroupMergeRequest(RESTObject):
@@ -1955,7 +1956,8 @@ def all(self, **kwargs):
         """
 
         path = '%s/all' % self.path
-        return self.gitlab.http_list(path, **kwargs)
+        obj = self.gitlab.http_list(path, **kwargs)
+        return [self._obj_cls(self, item) for item in obj]
 
 
 class ProjectNote(RESTObject):
