Make ProjectCommitStatus.create work with CLI

Gauvain Pocentek · Gauvain Pocentek · commit 34c8a03462e4 · 2018-06-06T08:10:47.000+02:00
Fixes #511
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
@@ -1201,6 +1201,7 @@ class ProjectCommitStatusManager(ListMixin, CreateMixin, RESTManager):
                      ('description', 'name', 'context', 'ref', 'target_url',
                       'coverage'))
 
+    @exc.on_http_error(exc.GitlabCreateError)
     def create(self, data, **kwargs):
         """Create a new object.
 
@@ -1218,9 +1219,15 @@ def create(self, data, **kwargs):
             RESTObject: A new instance of the manage object class build with
                         the data sent by the server
         """
-        path = '/projects/%(project_id)s/statuses/%(commit_id)s'
-        computed_path = self._compute_path(path)
-        return CreateMixin.create(self, data, path=computed_path, **kwargs)
+        # project_id and commit_id are in the data dict when using the CLI, but
+        # they are missing when using only the API
+        # See #511
+        base_path = '/projects/%(project_id)s/statuses/%(commit_id)s'
+        if 'project_id' in data and 'commit_id' in data:
+            path = base_path % data
+        else:
+            path = self._compute_path(base_path)
+        return CreateMixin.create(self, data, path=path, **kwargs)
 
 
 class ProjectCommitComment(RESTObject):
