fix: iids not working as a list in projects.issues.list()

JohnVillalovos · JohnVillalovos · commit 45f806c7a735 · 2021-04-27T08:19:12.000-07:00
Set the 'iids' values as type ListAttribute so it will pass the list as a comma-separated string, instead of a list. Add a functional test. Closes: #1407
diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py
@@ -220,7 +220,7 @@ class ProjectIssueManager(CRUDMixin, RESTManager):
             "discussion_locked",
         ),
     )
-    _types = {"labels": types.ListAttribute}
+    _types = {"iids": types.ListAttribute, "labels": types.ListAttribute}
 
 
 class ProjectIssueLink(ObjectDeleteMixin, RESTObject):
diff --git a/tools/functional/api/test_issues.py b/tools/functional/api/test_issues.py
@@ -4,7 +4,11 @@
 def test_create_issue(project):
     issue = project.issues.create({"title": "my issue 1"})
     issue2 = project.issues.create({"title": "my issue 2"})
-    assert len(project.issues.list()) == 2
+    issue_ids = [issue.id for issue in project.issues.list()]
+    assert len(issue_ids) == 2
+
+    # Test 'iids' as a list
+    assert len(project.issues.list(iids=issue_ids)) == 2
 
     issue2.state_event = "close"
     issue2.save()

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ class ProjectIssueManager(CRUDMixin, RESTManager):`
`220`	`220`	`"discussion_locked",`
`221`	`221`	`),`
`222`	`222`	`)`
`223`		`- _types = {"labels": types.ListAttribute}`
	`223`	`+ _types = {"iids": types.ListAttribute, "labels": types.ListAttribute}`
`224`	`224`
`225`	`225`
`226`	`226`	`class ProjectIssueLink(ObjectDeleteMixin, RESTObject):`