test: skip deletion of descendant groups in reset_gitlab

Shreya-7 · Shreya-7 · commit 4713f4ef845f · 2022-10-29T21:03:38.000+05:30
diff --git a/tests/functional/conftest.py b/tests/functional/conftest.py
@@ -98,20 +98,16 @@ def reset_gitlab(gl: gitlab.Gitlab) -> None:
     full_paths = [group.full_path for group in gl.groups.list()]
     logging.info(f"Groups to be deleted: {full_paths}")
     for group in gl.groups.list():
-        logging.info(f"Current group: {group.full_path!r}, group_id: {group.get_id()}")
-        descendant_full_paths = [
-            group.full_path
-            for group in group.descendant_groups.list(order_by="id", sort="desc")
-        ]
-        logging.info(f"Descendant groups to be deleted: {descendant_full_paths}")
-        for descendant_group in group.descendant_groups.list(
-            order_by="id", sort="desc"
-        ):
+
+        # skip deletion of a descendant group to prevent scenarios where parent group gets deleted leaving a dangling descendant whose deletion will throw 404s.
+        # descendant groups cannot contain the `/` special character: https://docs.gitlab.com/ee/user/reserved_names.html#limitations-on-project-and-group-names
+        if "/" in group.full_path:
             logging.info(
-                f"Current group: {descendant_group.full_path!r}, group_id: {descendant_group.get_id()}"
+                f"Skipping deletion of {group.full_path} as it is a descendant group"
             )
-            logging.info(f"Deleting descendant group: {descendant_group.full_path!r}")
-            helpers.safe_delete(descendant_group)
+            continue
+
+        logging.info(f"Current group: {group.full_path!r}, group_id: {group.get_id()}")
         for deploy_token in group.deploytokens.list():
             logging.info(
                 f"Deleting deploy token: {deploy_token.username!r} in "
