test: cover .get_id() paths

TimKnight-DWP · JohnVillalovos · commit 4aab77f50b32 · 2024-05-13T14:25:14.000-07:00
Signed-off-by: Tim Knight &lt;tim.knight1@engineering.digital.dwp.gov.uk&gt;
diff --git a/gitlab/v4/objects/job_token_scope.py b/gitlab/v4/objects/job_token_scope.py
@@ -44,9 +44,9 @@ def get_id(self) -> int:
         """Returns the id of the resource. This override deals with
         the fact that either an `id` or a `target_project_id` attribute
         is returned by the server depending on the endpoint called."""
-        project_id = cast(int, super().get_id())
-        if project_id is not None:
-            return project_id
+        target_project_id = cast(int, super().get_id())
+        if target_project_id is not None:
+            return target_project_id
         return cast(int, self.id)
 
 
@@ -64,9 +64,9 @@ def get_id(self) -> int:
         """Returns the id of the resource. This override deals with
         the fact that either an `id` or a `target_group_id` attribute
         is returned by the server depending on the endpoint called."""
-        group_id = cast(int, super().get_id())
-        if group_id is not None:
-            return group_id
+        target_group_id = cast(int, super().get_id())
+        if target_group_id is not None:
+            return target_group_id
         return cast(int, self.id)
 
 
diff --git a/tests/unit/objects/test_job_token_scope.py b/tests/unit/objects/test_job_token_scope.py
@@ -174,6 +174,7 @@ def test_get_projects_allowlist(job_token_scope, resp_get_allowlist):
 
     allowlist_content = allowlist.list()
     assert isinstance(allowlist_content, list)
+    assert allowlist_content[0].get_id() == 4
 
 
 def test_add_project_to_allowlist(job_token_scope, resp_add_to_allowlist):
@@ -190,6 +191,7 @@ def test_get_groups_allowlist(job_token_scope, resp_get_groups_allowlist):
 
     allowlist_content = allowlist.list()
     assert isinstance(allowlist_content, list)
+    assert allowlist_content[0].get_id() == 4
 
 
 def test_add_group_to_allowlist(job_token_scope, resp_add_to_groups_allowlist):
