Skip to content

Commit 5e07faf

Browse files
committed
feat(api): add merge request approval state
Add support for merge request approval state
1 parent 5a1678f commit 5e07faf

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

docs/gl_objects/mr_approvals.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ References
2121
+ :class:`gitlab.v4.objects.ProjectMergeRequestApprovalRule`
2222
+ :class:`gitlab.v4.objects.ProjectMergeRequestApprovalRuleManager`
2323
+ :attr:`gitlab.v4.objects.ProjectMergeRequest.approval_rules`
24+
+ :class:`gitlab.v4.objects.ProjectMergeRequestApprovalState`
25+
+ :class:`gitlab.v4.objects.ProjectMergeRequestApprovalStateManager`
26+
+ :attr:`gitlab.v4.objects.ProjectMergeRequest.approval_state`
2427

2528
* GitLab API: https://docs.gitlab.com/ee/api/merge_request_approvals.html
2629

@@ -46,6 +49,10 @@ Get project-level or MR-level MR approvals settings::
4649

4750
mr_mras = mr.approvals.get()
4851

52+
Get MR-level approval state::
53+
54+
mr_approval_state = mr.approval_state.get()
55+
4956
Change project-level or MR-level MR approvals settings::
5057

5158
p_mras.approvals_before_merge = 2

gitlab/v4/objects/merge_request_approvals.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
"ProjectMergeRequestApprovalManager",
2020
"ProjectMergeRequestApprovalRule",
2121
"ProjectMergeRequestApprovalRuleManager",
22+
"ProjectMergeRequestApprovalState",
23+
"ProjectMergeRequestApprovalStateManager",
2224
]
2325

2426

@@ -204,3 +206,13 @@ def create(self, data, **kwargs):
204206
new_data["id"] = self._from_parent_attrs["project_id"]
205207
new_data["merge_request_iid"] = self._from_parent_attrs["mr_iid"]
206208
return CreateMixin.create(self, new_data, **kwargs)
209+
210+
211+
class ProjectMergeRequestApprovalState(RESTObject):
212+
pass
213+
214+
215+
class ProjectMergeRequestApprovalStateManager(GetWithoutIdMixin, RESTManager):
216+
_path = "/projects/%(project_id)s/merge_requests/%(mr_iid)s/approval_state"
217+
_obj_cls = ProjectMergeRequestApprovalState
218+
_from_parent_attrs = {"project_id": "project_id", "mr_iid": "iid"}

gitlab/v4/objects/merge_requests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
from .merge_request_approvals import ( # noqa: F401
2727
ProjectMergeRequestApprovalManager,
2828
ProjectMergeRequestApprovalRuleManager,
29+
ProjectMergeRequestApprovalStateManager,
2930
)
3031
from .notes import ProjectMergeRequestNoteManager # noqa: F401
3132
from .pipelines import ProjectMergeRequestPipelineManager # noqa: F401
@@ -140,6 +141,7 @@ class ProjectMergeRequest(
140141
_id_attr = "iid"
141142

142143
approval_rules: ProjectMergeRequestApprovalRuleManager
144+
approval_state: ProjectMergeRequestApprovalStateManager
143145
approvals: ProjectMergeRequestApprovalManager
144146
awardemojis: ProjectMergeRequestAwardEmojiManager
145147
diffs: "ProjectMergeRequestDiffManager"

0 commit comments

Comments
 (0)