fix(cli): project-merge-request-approval-rule

JohnVillalovos · JohnVillalovos · commit 6945c56c48c9 · 2022-06-10T19:42:41.000-07:00
Using the CLI the command: gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar Would raise an exception. This was due to the fact that `_id_attr` and `_repr_attr` were set for keys which are not returned in the response. Closes: #2065
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -165,8 +165,6 @@ def set_approvers(
 
 
 class ProjectMergeRequestApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject):
-    _id_attr = "approval_rule_id"
-    _repr_attr = "approval_rule"
     id: int
     approval_rule_id: int
     merge_request_iid: int
diff --git a/tests/functional/cli/test_cli_v4.py b/tests/functional/cli/test_cli_v4.py
@@ -224,6 +224,21 @@ def test_create_merge_request(gitlab_cli, project):
     assert ret.success
 
 
+def test_project_merge_request_approval_rule(gitlab_cli, project):
+    mr = project.mergerequests.list()[0]
+    cmd = [
+        "project-merge-request-approval-rule",
+        "list",
+        "--project-id",
+        project.id,
+        "--mr-iid",
+        mr.iid,
+    ]
+    ret = gitlab_cli(cmd)
+
+    assert ret.success
+
+
 def test_accept_request_merge(gitlab_cli, project):
     # MR needs at least 1 commit before we can merge
     mr = project.mergerequests.list()[0]
