fix(objects): add default name data and use http post

Charles · Charles · commit 70c0cfb68617 · 2020-02-15T15:20:56.000+02:00
Updating approvers new api needs a POST call. Also It needs a name of the new rule, defaulting this to 'name'.
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py
@@ -2707,12 +2707,13 @@ def set_approvers(
             self._parent.get_id(),
         )
         data = {
-            "approvals_required": approvals_required,
+            "name": "name",
+            "self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required,
             "rule_type": "regular",
             "user_ids": approver_ids,
             "group_ids": approver_group_ids,
         }
-        self.gitlab.http_put(path, post_data=data, **kwargs)
+        self.gitlab.http_post(path, post_data=data, **kwargs)
 
 
 class ProjectMergeRequestAwardEmoji(ObjectDeleteMixin, RESTObject):

Original file line number	Diff line number	Diff line change
`@@ -2707,12 +2707,13 @@ def set_approvers(`
`2707`	`2707`	`self._parent.get_id(),`
`2708`	`2708`	`)`
`2709`	`2709`	`data = {`
`2710`		`- "approvals_required": approvals_required,`
	`2710`	`+ "name": "name",`
	`2711`	`+ "self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required,`
`2711`	`2712`	`"rule_type": "regular",`
`2712`	`2713`	`"user_ids": approver_ids,`
`2713`	`2714`	`"group_ids": approver_group_ids,`
`2714`	`2715`	`}`
`2715`		`- self.gitlab.http_put(path, post_data=data, **kwargs)`
	`2716`	`+ self.gitlab.http_post(path, post_data=data, **kwargs)`
`2716`	`2717`
`2717`	`2718`
`2718`	`2719`	`class ProjectMergeRequestAwardEmoji(ObjectDeleteMixin, RESTObject):`