Skip to content

Commit 88388fe

Browse files
author
Charles
committed
fix(docs and tests): update docs and tests for set_approvers
Updated the docs with the new set_approvers arguments, and updated tests with the arg as well.
1 parent 854d69e commit 88388fe

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/gl_objects/mr_approvals.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ Change project-level or MR-level MR allowed approvers::
5656
project.approvals.set_approvers(approver_ids=[105],
5757
approver_group_ids=[653, 654])
5858

59-
mr.approvals.set_approvers(approver_ids=[105],
59+
mr.approvals.set_approvers(approvals_required = 1, approver_ids=[105],
6060
approver_group_ids=[653, 654])

tools/ee-test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def end_log():
3737
approval.save()
3838
approval = project1.approvals.get()
3939
assert v != approval.reset_approvals_on_push
40-
project1.approvals.set_approvers([1], [])
40+
project1.approvals.set_approvers(1, [1], [])
4141
approval = project1.approvals.get()
4242
assert approval.approvers[0]["user"]["id"] == 1
4343

@@ -50,7 +50,7 @@ def end_log():
5050
approval.save()
5151
approval = mr.approvals.get()
5252
assert approval.approvals_required == 3
53-
mr.approvals.set_approvers([1], [])
53+
mr.approvals.set_approvers(1, [1], [])
5454
approval = mr.approvals.get()
5555
assert approval.approvers[0]["user"]["id"] == 1
5656

0 commit comments

Comments
 (0)