chore: remove set_approvals() method

JohnVillalovos · JohnVillalovos · commit 99d27fe3f034 · 2022-10-18T23:02:15.000-07:00
The `set_approvals()` method used the `/projects/:id/approvers` end point. That end point was removed from GitLab in the 13.11 release, on 2-Apr-2021 in commit 27dc2f2fe81249bbdc25f7bd8fe799752aac05e6 via merge commit e482597a8cf1bae8e27abd6774b684fb90491835 See merge request: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57473
diff --git a/docs/gl_objects/merge_request_approvals.rst b/docs/gl_objects/merge_request_approvals.rst
@@ -58,22 +58,9 @@ Change project-level or MR-level MR approvals settings::
     p_mras.approvals_before_merge = 2
     p_mras.save()
 
-    mr.approvals.set_approvers(approvals_required=1)
-    # or
     mr_mras.approvals_required = 1
     mr_mras.save()
 
-Change project-level MR allowed approvers::
-
-    project.approvals.set_approvers(approver_ids=[105],
-                                    approver_group_ids=[653, 654])
-
-Create a new MR-level approval rule or change an existing MR-level approval rule::
-
-    mr.approvals.set_approvers(approvals_required = 1, approver_ids=[105],
-                               approver_group_ids=[653, 654],
-                               approval_rule_name="my MR custom approval rule")
-
 List MR-level MR approval rules::
 
     mr.approval_rules.list()
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -50,38 +50,6 @@ class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager):
     def get(self, **kwargs: Any) -> ProjectApproval:
         return cast(ProjectApproval, super().get(**kwargs))
 
-    @exc.on_http_error(exc.GitlabUpdateError)
-    def set_approvers(
-        self,
-        approver_ids: Optional[List[int]] = None,
-        approver_group_ids: Optional[List[int]] = None,
-        **kwargs: Any,
-    ) -> Dict[str, Any]:
-        """Change project-level allowed approvers and approver groups.
-
-        Args:
-            approver_ids: User IDs that can approve MRs
-            approver_group_ids: Group IDs whose members can approve MRs
-
-        Raises:
-            GitlabAuthenticationError: If authentication is not correct
-            GitlabUpdateError: If the server failed to perform the request
-
-        Returns:
-            A dict value of the result
-        """
-        approver_ids = approver_ids or []
-        approver_group_ids = approver_group_ids or []
-
-        if TYPE_CHECKING:
-            assert self._parent is not None
-        path = f"/projects/{self._parent.encoded_id}/approvers"
-        data = {"approver_ids": approver_ids, "approver_group_ids": approver_group_ids}
-        result = self.gitlab.http_put(path, post_data=data, **kwargs)
-        if TYPE_CHECKING:
-            assert isinstance(result, dict)
-        return result
-
 
 class ProjectApprovalRule(SaveMixin, ObjectDeleteMixin, RESTObject):
     _id_attr = "id"
diff --git a/tests/unit/objects/test_project_merge_request_approvals.py b/tests/unit/objects/test_project_merge_request_approvals.py
@@ -183,45 +183,6 @@ def test_delete_merge_request_approval_rule(project, resp_delete_mr_approval_rul
     merge_request.approval_rules.delete(approval_rule_id)
 
 
-def test_update_merge_request_approvals_set_approvers(project, resp_mr_approval_rules):
-    approvals = project.mergerequests.get(1, lazy=True).approvals
-    assert isinstance(
-        approvals,
-        gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager,
-    )
-    assert approvals._update_uses_post is True
-    response = approvals.set_approvers(
-        updated_approval_rule_approvals_required,
-        approver_ids=updated_approval_rule_user_ids,
-        approver_group_ids=group_ids,
-        approval_rule_name=approval_rule_name,
-    )
-
-    assert response.approvals_required == updated_approval_rule_approvals_required
-    assert len(response.eligible_approvers) == len(updated_approval_rule_user_ids)
-    assert response.eligible_approvers[0]["id"] == updated_approval_rule_user_ids[0]
-    assert response.name == approval_rule_name
-
-
-def test_create_merge_request_approvals_set_approvers(project, resp_mr_approval_rules):
-    approvals = project.mergerequests.get(1, lazy=True).approvals
-    assert isinstance(
-        approvals,
-        gitlab.v4.objects.merge_request_approvals.ProjectMergeRequestApprovalManager,
-    )
-    assert approvals._update_uses_post is True
-    response = approvals.set_approvers(
-        new_approval_rule_approvals_required,
-        approver_ids=new_approval_rule_user_ids,
-        approver_group_ids=group_ids,
-        approval_rule_name=new_approval_rule_name,
-    )
-    assert response.approvals_required == new_approval_rule_approvals_required
-    assert len(response.eligible_approvers) == len(new_approval_rule_user_ids)
-    assert response.eligible_approvers[0]["id"] == new_approval_rule_user_ids[0]
-    assert response.name == new_approval_rule_name
-
-
 def test_create_merge_request_approval_rule(project, resp_mr_approval_rules):
     approval_rules = project.mergerequests.get(1, lazy=True).approval_rules
     data = {
