Merge pull request #1488 from JohnVillalovos/jlvillal/add_missing_option

nejch · web-flow · commit ac922054eb22 · 2021-06-01T08:32:33.000+02:00
chore: add missing optional create parameter for approval_rules
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -72,7 +72,8 @@ class ProjectApprovalRuleManager(
     _obj_cls = ProjectApprovalRule
     _from_parent_attrs = {"project_id": "id"}
     _create_attrs = RequiredOptional(
-        required=("name", "approvals_required"), optional=("user_ids", "group_ids")
+        required=("name", "approvals_required"),
+        optional=("user_ids", "group_ids", "protected_branch_ids"),
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,8 @@ class ProjectApprovalRuleManager(`
`72`	`72`	`_obj_cls = ProjectApprovalRule`
`73`	`73`	`_from_parent_attrs = {"project_id": "id"}`
`74`	`74`	`_create_attrs = RequiredOptional(`
`75`		`- required=("name", "approvals_required"), optional=("user_ids", "group_ids")`
	`75`	`+ required=("name", "approvals_required"),`
	`76`	`+ optional=("user_ids", "group_ids", "protected_branch_ids"),`
`76`	`77`	`)`
`77`	`78`
`78`	`79`