Skip to content

Commit b87a2bc

Browse files
chore: bump GitLab docker image to 15.4.0-ee.0
* Use `settings.delayed_group_deletion=False` as that is the recommended method to turn off the delayed group deletion now. * Change test to look for `default` as `pages` is not mentioned in the docs[1] [1] https://docs.gitlab.com/ee/api/sidekiq_metrics.html#get-the-current-queue-metrics
1 parent 86b0e40 commit b87a2bc

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

tests/functional/api/test_gitlab.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def test_lint(gl):
5959
def test_sidekiq_queue_metrics(gl):
6060
out = gl.sidekiq.queue_metrics()
6161
assert isinstance(out, dict)
62-
assert "pages" in out["queues"]
62+
assert "default" in out["queues"]
6363

6464

6565
def test_sidekiq_process_metrics(gl):

tests/functional/conftest.py

+11-4
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,18 @@ def reset_gitlab(gl: gitlab.Gitlab) -> None:
6868
if is_gitlab_ee(gl):
6969
logging.info("GitLab EE detected")
7070
# NOTE(jlvillal): By default in GitLab EE it will wait 7 days before
71-
# deleting a group. Change it to 0 days.
71+
# deleting a group. Disable delayed group/project deletion.
7272
settings = gl.settings.get()
73-
if settings.deletion_adjourned_period != 0:
74-
logging.info("Setting deletion_adjourned_period to 0")
75-
settings.deletion_adjourned_period = 0
73+
modified_settings = False
74+
if settings.delayed_group_deletion:
75+
logging.info("Setting `delayed_group_deletion` to False")
76+
settings.delayed_group_deletion = False
77+
modified_settings = True
78+
if settings.delayed_project_deletion:
79+
logging.info("Setting `delayed_project_deletion` to False")
80+
settings.delayed_project_deletion = False
81+
modified_settings = True
82+
if modified_settings:
7683
settings.save()
7784

7885
for project in gl.projects.list():

tests/functional/fixtures/.env

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
GITLAB_IMAGE=gitlab/gitlab-ee
2-
GITLAB_TAG=15.2.0-ee.0
2+
GITLAB_TAG=15.4.0-ee.0

0 commit comments

Comments
 (0)