Fix and test pagination

Gauvain Pocentek · Gauvain Pocentek · commit c08c913b82bf · 2016-09-03T18:39:07.000+02:00
Fixes #140
diff --git a/gitlab/__init__.py b/gitlab/__init__.py
@@ -365,14 +365,14 @@ def _raw_list(self, path, cls, extra_attrs={}, **kwargs):
 
         get_all_results = kwargs.get('all', False)
 
+        r = self._raw_get(path, **params)
+        raise_error_from_response(r, GitlabListError)
+
         # Remove parameters from kwargs before passing it to constructor
         for key in ['all', 'page', 'per_page', 'sudo', 'next_url']:
             if key in params:
                 del params[key]
 
-        r = self._raw_get(path, **params)
-        raise_error_from_response(r, GitlabListError)
-
         # Add _from_api manually, because we are not creating objects
         # through normal path
         params['_from_api'] = True
diff --git a/tools/python_test.py b/tools/python_test.py
@@ -136,6 +136,13 @@
 assert(len(gl.projects.owned()) == 2)
 assert(len(gl.projects.search("admin")) == 1)
 
+# test pagination
+l1 = gl.projects.list(per_page=1, page=1)
+l2 = gl.projects.list(per_page=1, page=2)
+assert(len(l1) == 1)
+assert(len(l2) == 1)
+assert(l1[0].id != l2[0].id)
+
 # project content (files)
 admin_project.files.create({'file_path': 'README',
                             'branch_name': 'master',
