Skip to content

Commit c56fc47

Browse files
committed
use 'docker stop' instead of 'docker kill'
The 'stop' command first tries SIGTERM before resorting to SIGKILL, which is a gentler way to stop processes. (SIGTERM gives processes an opportunity to clean up before exiting; SIGKILL can't be caught so it is very abrupt.)
1 parent 2609cbb commit c56fc47

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/build_test_env.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ CONFIG=/tmp/python-gitlab.cfg
5555

5656
cleanup() {
5757
rm -f "${CONFIG}"
58-
log "Killing gitlab-test docker container..."
59-
docker kill gitlab-test >/dev/null 2>&1
58+
log "Stopping gitlab-test docker container..."
59+
docker stop gitlab-test >/dev/null 2>&1
6060
log "Removing gitlab-test docker container..."
6161
docker rm gitlab-test >/dev/null 2>&1
6262
log "Deactivating Python virtualenv..."

0 commit comments

Comments
 (0)