Skip to content

Commit f825d70

Browse files
nejchJohnVillalovos
authored andcommitted
refactor(deps): drop compose v1 dependency in favor of v2
1 parent 953f38d commit f825d70

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

CONTRIBUTING.rst

+5-3
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,10 @@ Running integration tests
7878
-------------------------
7979

8080
Integration tests run against a running gitlab instance, using a docker
81-
container. You need to have docker installed on the test machine, and your user
82-
must have the correct permissions to talk to the docker daemon.
81+
container. You need to have docker and `docker compose
82+
<https://docs.docker.com/compose/install/>`_
83+
installed on the test machine, and your user must have the correct permissions
84+
to talk to the docker daemon.
8385

8486
To run these tests:
8587

@@ -104,7 +106,7 @@ up of the containers by running:
104106

105107
.. code-block:: bash
106108
107-
docker-compose -f tests/functional/fixtures/docker-compose.yml -p pytest-python-gitlab down -v
109+
docker compose -f tests/functional/fixtures/docker-compose.yml -p pytest-python-gitlab down -v
108110
109111
By default, the tests run against the latest version of the ``gitlab/gitlab-ce``
110112
image. You can override both the image and tag by providing either the

requirements-docker.txt

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
-r requirements.txt
22
-r requirements-test.txt
3-
docker-compose==1.29.2 # prevent inconsistent .env behavior from system install
43
pytest-docker

tests/functional/conftest.py

+5
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ def gitlab_version(gl) -> GitlabVersion:
3434
return GitlabVersion(major=major, minor=minor, patch=patch, revision=revision)
3535

3636

37+
@pytest.fixture(scope="session")
38+
def docker_compose_command():
39+
return "docker compose"
40+
41+
3742
@pytest.fixture(scope="session")
3843
def fixture_dir(test_dir) -> pathlib.Path:
3944
return test_dir / "functional" / "fixtures"

0 commit comments

Comments
 (0)