Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-gitlab/python-gitlab
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.1
Choose a base ref
...
head repository: python-gitlab/python-gitlab
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.0
Choose a head ref
  • 20 commits
  • 47 files changed
  • 7 contributors

Commits on Jan 10, 2025

  1. feat(api): Narrow down return type of download methods using typing.o…

    …verload
    
    Currently the download methods such as `ProjectJob.artifacts` have
    return type set to `Optional[Union[bytes, Iterator[Any]]]` which
    means they return either `None` or `bytes` or `Iterator[Any]`.
    
    However, the actual return type is determined by the passed
    `streamed` and `iterator` arguments. Using `@typing.overload`
    decorator it is possible to return a single type based on the
    passed arguments.
    
    Add overloads in the following order to all download methods:
    
    1. If `streamed=False` and `iterator=False` return `bytes`. This
       is the default argument values therefore it should be first as
       it will be used to lookup default arguments.
    2. If `iterator=True` return `Iterator[Any]`. This can be combined
       with both `streamed=True` and `streamed=False`.
    3. If `streamed=True` and `iterator=False` return `None`. In this
       case `action` argument can be set to a callable that accepts
       `bytes`.
    
    Signed-off-by: Igor Ponomarev <igor.ponomarev@collabora.com>
    igorp-collabora authored and JohnVillalovos committed Jan 10, 2025
    Configuration menu
    Copy the full SHA
    44fd9dc View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2025

  1. chore(deps): update gitlab/gitlab-ee docker tag to v17.7.1-ee.0 (#3082)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    1e95944 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2025

  1. fix(api): Make type ignores more specific where possible

    Instead of using absolute ignore `# type: ignore` use a more
    specific ignores like `# type: ignore[override]`. This might help
    in the future where a new bug might be introduced and get ignored
    by a general ignore comment but not a more specific one.
    
    Signed-off-by: Igor Ponomarev <igor.ponomarev@collabora.com>
    igorp-collabora authored and JohnVillalovos committed Jan 15, 2025
    Configuration menu
    Copy the full SHA
    e3cb806 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2025

  1. chore(deps): update mypy to 1.14 and resolve issues

    mypy 1.14 has a change to Enum Membership Semantics:
    https://mypy.readthedocs.io/en/latest/changelog.html
    
    Resolve the issues with Enum and typing, and update mypy to 1.14
    JohnVillalovos authored and nejch committed Jan 20, 2025
    Configuration menu
    Copy the full SHA
    671e711 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2025

  1. ci: use gitlab-runner:v17.7.1 for the CI

    The `latest` gitlab-runner image does not have the `gitlab-runner`
    user and it causes our tests to fail.
    
    Closes: #3091
    JohnVillalovos authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    2dda9dc View commit details
    Browse the repository at this point in the history
  2. chore(test): prevent 'job_with_artifact' fixture running forever

    Previously the 'job_with_artifact' fixture could run forever. Now give
    it up to 60 seconds to complete before failing.
    JohnVillalovos authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    e4673d8 View commit details
    Browse the repository at this point in the history
  3. feat(api): Add argument that appends extra HTTP headers to a request

    Currently the only way to manipulate the headers for a request
    is to use `Gitlab.headers` attribute. However, this makes it
    very concurrently unsafe because the `Gitlab` object can be shared
    between multiple requests at the same time.
    
    Instead add a new keyword argument `extra_headers` which will update
    the headers dictionary with new values just before the request is sent.
    
    For example, this can be used to download a part of a artifacts file
    using the `Range` header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests
    
    Signed-off-by: Igor Ponomarev <igor.ponomarev@collabora.com>
    igorp-collabora authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    fb07b5c View commit details
    Browse the repository at this point in the history
  4. fix(files): add optional ref parameter for cli project-file raw (#3032)

    The 
    ef parameter was removed in python-gitlab v4.8.0.  This will add 
    ef back as an optional parameter for the project-file raw cli command.
    ebishop authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    22f03bd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cbd4263 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba75c31 View commit details
    Browse the repository at this point in the history
  7. chore: fix warning being generated

    The CI shows a warning. Use `get_all=False` to resolve issue.
    JohnVillalovos authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    0eb5eb0 View commit details
    Browse the repository at this point in the history
  8. chore: fix pytest deprecation

    pytest has changed the function argument name to `start_path`
    JohnVillalovos authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    95db680 View commit details
    Browse the repository at this point in the history
  9. chore: resolve DeprecationWarning message in CI run

    Catch the DeprecationWarning in our test, as we expect it.
    JohnVillalovos authored and nejch committed Jan 22, 2025
    Configuration menu
    Copy the full SHA
    accd5aa View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2025

  1. chore(ci): set a 30 minute timeout for 'functional' tests

    Currently the functional API test takes around 17 minutes to run. And
    the functional CLI test takes around 12 minutes to run.
    
    Occasionally a job gets stuck and will sit until the default 360
    minutes job timeout occurs.
    
    Now have a 30 minute timeout for the 'functional' tests.
    JohnVillalovos authored and nejch committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    e8d6953 View commit details
    Browse the repository at this point in the history
  2. chore(deps): update gitlab (#3088)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Jan 23, 2025
    Configuration menu
    Copy the full SHA
    9214b83 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2025

  1. Configuration menu
    Copy the full SHA
    939505b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de29503 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    175b355 View commit details
    Browse the repository at this point in the history
  4. feat(api): Narrow down return type of ProjectFileManager.raw using ty…

    …ping.overload
    
    This is equivalent to the changes in 44fd9dc
    but for `ProjectFileManager.raw` method that I must have missed
    in the original commit.
    
    Signed-off-by: Igor Ponomarev <igor.ponomarev@collabora.com>
    igorp-collabora authored and nejch committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    36d9b24 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2025

  1. chore: release v5.4.0

    semantic-release committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    30f470b View commit details
    Browse the repository at this point in the history
Loading