-
Notifications
You must be signed in to change notification settings - Fork 668
Add ban/unban and approve/reject methods to User #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As requested in python-gitlab#1604.
As requested in python-gitlab#1604.
As requested in python-gitlab#1604.
As requested in python-gitlab#1604.
As requested in python-gitlab#1604.
@antoineauger as discussed if you want a break from k8s and work on this 😁 There's a PR that implements approve/reject endpoints for this issue in #2061 - you could do the same for ban/unban: See my comments in the other PR for a bit of guidance, although ideally we'd also have 1 response per mock and 1 assert per test so we can remove In the case of ban/unban I think we could also add a quick functional test like for block/unblock. https://github.com/python-gitlab/python-gitlab/blob/main/tests/functional/api/test_users.py#L30-L37. With both PRs in we could then close this issue. Of course if there's any hiccups along the way I'm happy to look at docs PRs as well if you feel like it 😀 |
As requested in python-gitlab#1604. Co-authored-by: John Villalovos <john@sodarock.com>
Description of the problem, including code/CLI snippet
API has endpoints to manage the state of a user:
The text was updated successfully, but these errors were encountered: