Skip to content

Merge Request Approvals API #877

Closed
Closed
@thuhc

Description

@thuhc

Description of the problem, including code/CLI snippet

Since GitLab 12.3, gitlab changed API for MR approvals
https://docs.gitlab.com/ee/api/merge_request_approvals.html
project.approvals.get() --> cannot get list approvals
<class 'gitlab.v4.objects.ProjectApproval'> => {'approvers': [], 'approver_groups': [], 'approvals_before_merge': 2, 'reset_approvals_on_push': True, 'disable_overriding_approvers_per_merge_request': True, 'merge_requests_author_approval': False, 'merge_requests_disable_committers_approval': False}

Expected Behavior

  • Integration to this new API for MR approvals: get list approvals, add/remove approvals

Actual Behavior

  • Update API for MR approvals

Specifications

  • python-gitlab version: 1.11
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com): 12.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    EEIssues related to the enterprise version of GitLabfeature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions