From 70c0cfb686177bc17b796bf4d7eea8b784cf9651 Mon Sep 17 00:00:00 2001 From: Charles Date: Sat, 15 Feb 2020 15:20:56 +0200 Subject: [PATCH] fix(objects): add default name data and use http post Updating approvers new api needs a POST call. Also It needs a name of the new rule, defaulting this to 'name'. --- gitlab/v4/objects.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index 6b60583fa..64442cea5 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -2707,12 +2707,13 @@ def set_approvers( self._parent.get_id(), ) data = { - "approvals_required": approvals_required, + "name": "name", + "self.assertEqual(expected, actual, 'message')pprovals_required": approvals_required, "rule_type": "regular", "user_ids": approver_ids, "group_ids": approver_group_ids, } - self.gitlab.http_put(path, post_data=data, **kwargs) + self.gitlab.http_post(path, post_data=data, **kwargs) class ProjectMergeRequestAwardEmoji(ObjectDeleteMixin, RESTObject):