Skip to content

chore: improve test environment for upcoming features #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2020
Merged

chore: improve test environment for upcoming features #1054

merged 4 commits into from
Mar 22, 2020

Conversation

nejch
Copy link
Member

@nejch nejch commented Mar 21, 2020

In #1052 and in some previous PRs, we've had to wait for a release to test new features on latest.

This PR allows contributors and CI (via either command-line flags or env variables) to define the image and tag to test against, and removes references to older python test environments.

Since nightly might be unstable I've added it to allow_failures so it's not blocking but at least provides some feedback on new features. This can later be combined with @skipif (or similar) to run tests only against versions equal or higher than a specific GitLab version to improve development for upcoming features.

@nejch nejch marked this pull request as ready for review March 22, 2020 00:06
@max-wittig
Copy link
Member

That's really cool!

@max-wittig max-wittig merged commit 8173021 into python-gitlab:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants