Skip to content

chore: use raise..from for chained exceptions (#939) #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

chore: use raise..from for chained exceptions (#939) #1059

merged 1 commit into from
Apr 7, 2020

Conversation

nejch
Copy link
Member

@nejch nejch commented Mar 29, 2020 •
edited
Loading

Closes #939. Trying to close some older issues that can be fixed with small changes. :P

@nejch nejch marked this pull request as ready for review April 5, 2020 13:37
@nejch nejch requested a review from max-wittig April 5, 2020 13:37
@nejch nejch changed the title fix: use raise..from for chained exceptions (#939) chore: use raise..from for chained exceptions (#939) Apr 5, 2020
max-wittig
max-wittig approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! LGTM 👍

@max-wittig max-wittig merged commit 6749859 into master Apr 7, 2020
@nejch nejch deleted the fix/raise-from branch May 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper usage of exceptions under Python3
2 participants
@nejch @max-wittig