chore(ci): add codecov integration to Travis #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
===========================================
+ Coverage 25.16% 76.68% +51.52%
===========================================
Files 16 10 -6
Lines 4598 2758 -1840
===========================================
+ Hits 1157 2115 +958
+ Misses 3441 643 -2798
Continue to review full report at Codecov.
|
bufferoverflow
approved these changes
Apr 25, 2020
|
Cool feature! |
max-wittig
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed adding some kind of coverage reporting, codecov seemed to be the easiest to add. After this is merged, codecov should also start reporting PR comments with a summary (on successful builds):
https://docs.codecov.io/docs/pull-request-comments
Edit: ah the summary is already here :) If this comment style is too intrusive, we can probably customize this to make it smaller with
codecov.yml. Looks like there was an initial run a few years ago, since this reports against an old master commit. I'll look into adding this as a separate check as well. Seems like we can later split unit and functional tests into separate checks with flags.