Skip to content

Update pipelines_and_jobs.rst #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

aparcar
Copy link
Contributor

@aparcar aparcar commented May 6, 2020

This uses a context instead of inventing your own stream handler which makes the code simpler and should be fine for most use cases.

@max-wittig
Copy link
Member

Looks good. Would you mind to change the commit message to something like:

docs(pipelines): simplify download or similar

This uses a context instead of inventing your own stream handler which
makes the code simpler and should be fine for most use cases.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@aparcar aparcar force-pushed the aparcar-patch-1 branch from 2c0f10b to 9a068e0 Compare May 7, 2020 08:40
@codecov-io
Copy link

Codecov Report

Merging #1092 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   76.68%   76.68%           
=======================================
  Files          10       10           
  Lines        2758     2758           
=======================================
  Hits         2115     2115           
  Misses        643      643           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b3ddc...9a068e0. Read the comment docs.

@max-wittig max-wittig merged commit 12a40cc into python-gitlab:master Jun 30, 2020
@max-wittig
Copy link
Member

Sorry for the delay and thanks for the docs fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants