Added support for HTTP basic authentication #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks good, thank you (will test ASAP). I'm a bit curious about how you use this though. Do you use both HTTP auth and token auth? Is there any reason why? |
|
Hi @gpocentek , yes, I use both: Certain gitlab servers that I use are protected behind a HTTP basic authentication interface. This protects them from potential issues in the gitlab API (think defense-in-depth). After that is the 'usual' gitlab authentication (either tokens or username/password). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for HTTP basic authentication
The username and password can be specified in the configuration file