From ad72ef35707529058c7c680f334c285746b2f690 Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 27 Feb 2021 12:45:41 -0800 Subject: [PATCH] chore: add additional type-hints for gitlab/base.py Add type-hints for the variables which are set via self.__dict__ mypy doesn't see them when they are assigned via self.__dict__. So declare them in the class definition. --- gitlab/base.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gitlab/base.py b/gitlab/base.py index 30f065951..a3fdcf7e6 100644 --- a/gitlab/base.py +++ b/gitlab/base.py @@ -16,6 +16,7 @@ # along with this program. If not, see . import importlib +from types import ModuleType from typing import Any, Dict, Optional, Type from .client import Gitlab, GitlabList @@ -38,7 +39,12 @@ class RESTObject(object): without ID in the url. """ - _id_attr = "id" + _id_attr: Optional[str] = "id" + _attrs: Dict[str, Any] + _module: ModuleType + _parent_attrs: Dict[str, Any] + _updated_attrs: Dict[str, Any] + manager: "RESTManager" def __init__(self, manager: "RESTManager", attrs: Dict[str, Any]) -> None: self.__dict__.update(