From 45f806c7a7354592befe58a76b7e33a6d5d0fe6e Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sat, 24 Apr 2021 17:12:43 -0700 Subject: [PATCH] fix: iids not working as a list in projects.issues.list() Set the 'iids' values as type ListAttribute so it will pass the list as a comma-separated string, instead of a list. Add a functional test. Closes: #1407 --- gitlab/v4/objects/issues.py | 2 +- tools/functional/api/test_issues.py | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py index cdaeaba3c..c3c35d325 100644 --- a/gitlab/v4/objects/issues.py +++ b/gitlab/v4/objects/issues.py @@ -220,7 +220,7 @@ class ProjectIssueManager(CRUDMixin, RESTManager): "discussion_locked", ), ) - _types = {"labels": types.ListAttribute} + _types = {"iids": types.ListAttribute, "labels": types.ListAttribute} class ProjectIssueLink(ObjectDeleteMixin, RESTObject): diff --git a/tools/functional/api/test_issues.py b/tools/functional/api/test_issues.py index ebff72b0f..6ab4b3374 100644 --- a/tools/functional/api/test_issues.py +++ b/tools/functional/api/test_issues.py @@ -4,7 +4,11 @@ def test_create_issue(project): issue = project.issues.create({"title": "my issue 1"}) issue2 = project.issues.create({"title": "my issue 2"}) - assert len(project.issues.list()) == 2 + issue_ids = [issue.id for issue in project.issues.list()] + assert len(issue_ids) == 2 + + # Test 'iids' as a list + assert len(project.issues.list(iids=issue_ids)) == 2 issue2.state_event = "close" issue2.save()