Skip to content

refactor(objects): remove deprecated members.all() method #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Sep 8, 2021

BREAKING CHANGE: remove deprecated members.all() method in favor of members_all.list()

@nejch nejch mentioned this pull request Sep 8, 2021
15 tasks
BREAKING CHANGE: remove deprecated members.all() method
in favor of members_all.list()
@nejch nejch force-pushed the chore/remove-members-all branch from ab4c30c to f6522d5 Compare September 8, 2021 21:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #1594 (f6522d5) into master (8236281) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
- Coverage   91.58%   91.53%   -0.05%     
==========================================
  Files          74       74              
  Lines        4312     4290      -22     
==========================================
- Hits         3949     3927      -22     
  Misses        363      363              
Flag Coverage Δ
cli_func_v4 81.37% <100.00%> (+0.04%) ⬆️
py_func_v4 80.60% <100.00%> (-0.06%) ⬇️
unit 83.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/mixins.py 91.12% <ø> (-0.36%) ⬇️
gitlab/v4/objects/members.py 100.00% <100.00%> (ø)
gitlab/v4/objects/pipelines.py 94.44% <0.00%> (-0.35%) ⬇️

@JohnVillalovos JohnVillalovos merged commit 4d7b848 into master Sep 9, 2021
@JohnVillalovos JohnVillalovos deleted the chore/remove-members-all branch September 9, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants