Skip to content

chore: rename master branch to main #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021
Merged

chore: rename master branch to main #1629

merged 1 commit into from
Oct 12, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Oct 9, 2021

BREAKING CHANGE: As of python-gitlab 3.0.0, the default branch for development
has changed from master to main.

GitHub changed on 1-10-2020, GitLab changed with 14.0.

Closes #1622. Will switch the branch in the project first before assigning this. Switched to main and pushed master again to have an old branch in case some people relied on it.

@nejch nejch mentioned this pull request Oct 9, 2021
15 tasks
@nejch nejch force-pushed the chore/master-to-main branch 2 times, most recently from 86255ca to 14fb924 Compare October 9, 2021 13:54
@nejch nejch marked this pull request as ready for review October 9, 2021 14:47
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me and would also be fine if master disappeared to remove the chance of confusion.

@JohnVillalovos
Copy link
Member

Also a thought. If decide to keep master maybe put in a final commit which deletes everything and directs people to use the main branch. Then master branch exists but won't cause confusion for people.

@nejch
Copy link
Member Author

nejch commented Oct 10, 2021

Fine with me and would also be fine if master disappeared to remove the chance of confusion.

That makes sense also, I'll see what other projects do but I think we can just remove it shortly after releasing and not keep stale branches

BREAKING CHANGE: As of python-gitlab 3.0.0, the default branch for development
has changed from `master` to `main`.
@nejch nejch force-pushed the chore/master-to-main branch from 14fb924 to 545f8ed Compare October 11, 2021 20:50
@nejch
Copy link
Member Author

nejch commented Oct 11, 2021

@JohnVillalovos I've removed the references to keeping an old master, I just remembered I also had some confusion while rebasing on the wrong branch with a project that kept it.. we can remove it after the release :P

@nejch nejch merged commit 63b2070 into main Oct 12, 2021
@nejch nejch deleted the chore/master-to-main branch October 12, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from master to main for default branch
3 participants